[
https://issues.apache.org/jira/browse/TINKERPOP-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941989#comment-17941989
]
ASF GitHub Bot commented on TINKERPOP-3047:
-------------------------------------------
Cole-Greer commented on code in PR #3091:
URL: https://github.com/apache/tinkerpop/pull/3091#discussion_r2033939903
##########
gremlin-language/src/test/java/org/apache/tinkerpop/gremlin/language/grammar/ReferenceGrammarTest.java:
##########
@@ -48,6 +52,7 @@
public class ReferenceGrammarTest extends AbstractGrammarTest {
private static final String featureDir = Paths.get("..", "gremlin-test",
"src", "main", "resources", "org", "apache", "tinkerpop", "gremlin", "test",
"features").toString();
private static final String docsDir = Paths.get("..", "docs",
"src").toString();
+ private static final String grammarFile = Paths.get("src", "main",
"antlr4","Gremlin.g4").toString();
Review Comment:
This appears to be unused
> Grammar does not parse keywords into Map keys
> ---------------------------------------------
>
> Key: TINKERPOP-3047
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3047
> Project: TinkerPop
> Issue Type: Bug
> Components: language
> Affects Versions: 3.7.1
> Reporter: Stephen Mallette
> Priority: Critical
>
> {{[keys: ["a","b"]}} won't work because "keys" ends up being parsed to
> {{Column.keys}}. another issue at play is the use of parens to wrap certain
> key definitions but not others. it doesn't feel consistent. like, it will
> work for {{T}} values but not for something like "edges" which is just a
> keyword token. Not sure it's wrong but it requires some examination.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
