[
https://issues.apache.org/jira/browse/TINKERPOP-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942033#comment-17942033
]
ASF GitHub Bot commented on TINKERPOP-3047:
-------------------------------------------
andreachild commented on code in PR #3091:
URL: https://github.com/apache/tinkerpop/pull/3091#discussion_r2034192178
##########
gremlin-language/src/main/antlr4/Gremlin.g4:
##########
@@ -67,34 +73,34 @@ traversalSourceSelfMethod
;
traversalSourceSelfMethod_withBulk
- : 'withBulk' LPAREN booleanArgument RPAREN
+ : K_WITHBULK LPAREN booleanArgument RPAREN
;
traversalSourceSelfMethod_withPath
- : 'withPath' LPAREN RPAREN
+ : K_WITHPATH LPAREN RPAREN
;
traversalSourceSelfMethod_withSack
- : 'withSack' LPAREN genericLiteralArgument RPAREN
- | 'withSack' LPAREN genericLiteralArgument COMMA
traversalBiFunctionArgument RPAREN
+ : K_WITHSACK LPAREN genericLiteralArgument RPAREN
+ | K_WITHSACK LPAREN genericLiteralArgument COMMA traversalBiFunction RPAREN
;
traversalSourceSelfMethod_withSideEffect
- : 'withSideEffect' LPAREN stringArgument COMMA genericLiteralArgument
RPAREN
- | 'withSideEffect' LPAREN stringArgument COMMA genericLiteralArgument
COMMA traversalBiFunctionArgument RPAREN
+ : K_WITHSIDEEFFECT LPAREN stringArgument COMMA genericLiteralArgument
RPAREN
+ | K_WITHSIDEEFFECT LPAREN stringArgument COMMA genericLiteralArgument
COMMA traversalBiFunction RPAREN
Review Comment:
Is the replacement of `traversalBiFunctionArgument` with
`traversalBiFunction` backwards compatible? The `traversalBiFunctionArgument`
(prior to its deletion in this PR) used to allow `variable` but
`traversalBiFunction` does not.
```
traversalBiFunctionArgument
: traversalBiFunction
| variable
;
```
```
traversalBiFunction
: traversalOperator
;
```
> Grammar does not parse keywords into Map keys
> ---------------------------------------------
>
> Key: TINKERPOP-3047
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3047
> Project: TinkerPop
> Issue Type: Bug
> Components: language
> Affects Versions: 3.7.1
> Reporter: Stephen Mallette
> Priority: Critical
>
> {{[keys: ["a","b"]}} won't work because "keys" ends up being parsed to
> {{Column.keys}}. another issue at play is the use of parens to wrap certain
> key definitions but not others. it doesn't feel consistent. like, it will
> work for {{T}} values but not for something like "edges" which is just a
> keyword token. Not sure it's wrong but it requires some examination.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
