[
https://issues.apache.org/jira/browse/TINKERPOP-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942266#comment-17942266
]
ASF GitHub Bot commented on TINKERPOP-3047:
-------------------------------------------
andreachild commented on code in PR #3091:
URL: https://github.com/apache/tinkerpop/pull/3091#discussion_r2035908288
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/grammar/GenericLiteralVisitor.java:
##########
@@ -331,33 +331,39 @@ public Object visitGenericLiteralMap(final
GremlinParser.GenericLiteralMapContex
// [key : value] - index 0 is key, index 1 is COLON, index 2 is
value
// also note that a child count of 5 indicates the key is an
expression wrapped
Review Comment:
This comment should be updated to reference the updated logic for
determining if the key is an expression (presence of left parenthesis) or
removed.
> Grammar does not parse keywords into Map keys
> ---------------------------------------------
>
> Key: TINKERPOP-3047
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3047
> Project: TinkerPop
> Issue Type: Bug
> Components: language
> Affects Versions: 3.7.1
> Reporter: Stephen Mallette
> Priority: Critical
>
> {{[keys: ["a","b"]}} won't work because "keys" ends up being parsed to
> {{Column.keys}}. another issue at play is the use of parens to wrap certain
> key definitions but not others. it doesn't feel consistent. like, it will
> work for {{T}} values but not for something like "edges" which is just a
> keyword token. Not sure it's wrong but it requires some examination.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
