[
https://issues.apache.org/jira/browse/TINKERPOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948241#comment-17948241
]
ASF GitHub Bot commented on TINKERPOP-3023:
-------------------------------------------
Cole-Greer commented on code in PR #3100:
URL: https://github.com/apache/tinkerpop/pull/3100#discussion_r2067032669
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/grammar/StructureElementVisitor.java:
##########
@@ -32,7 +32,11 @@ public StructureElementVisitor(final GremlinAntlrToJava
antlr) {
@Override
public Vertex visitStructureVertex(final
GremlinParser.StructureVertexContext ctx) {
- return new
ReferenceVertex(antlr.argumentVisitor.visitGenericLiteralArgument(ctx.genericLiteralArgument()),
- (String)
antlr.argumentVisitor.visitStringArgument(ctx.stringArgument()));
+ if (ctx.getChildCount() == 4) {
Review Comment:
Nit: Prefer to use `if (ctx.stringArgument() == null)` instead of checking
the child count.
> Expand type syntax in grammar in 3.8
> ------------------------------------
>
> Key: TINKERPOP-3023
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3023
> Project: TinkerPop
> Issue Type: Improvement
> Components: language
> Affects Versions: 3.8.0
> Reporter: Stephen Mallette
> Priority: Major
>
> There are certain types commonly used in Gremlin that should have some native
> support in the grammar:
> * UUID
> ** {{UUID()}} - random
> ** {{UUID('1e077e63-e45a-4f8e-aa00-9b6ffd91f20e')}}
> * Edge
> ** {{Edge(11)}} - different than current syntax for Vertex, adjust Vertex to
> match - drop grammar support for {{{}ReferenceVertex{}}}.
> * Binary (ByteBuffer)
> ** {{Binary( '/9j/4AAQSkZJRgABAQEAAAAAAAD/==')}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
