[ 
https://issues.apache.org/jira/browse/TINKERPOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948588#comment-17948588
 ] 

ASF GitHub Bot commented on TINKERPOP-3023:
-------------------------------------------

Cole-Greer commented on code in PR #3104:
URL: https://github.com/apache/tinkerpop/pull/3104#discussion_r2069433659


##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/language/translator/GremlinTranslatorTest.java:
##########
@@ -151,6 +151,15 @@ public static Collection<Object[]> data() {
                             null,
                             "g.with_(\"x\")",
                             "g.with_('x')"},
+                    
{"g.inject(UUID(\"f47ac10b-58cc-4372-a567-0e02b2c3d479\"))",
+                            null,
+                            "g.inject(string0)",
+                            
"g.Inject<object>(Guid.Parse(\"f47ac10b-58cc-4372-a567-0e02b2c3d479\"))",
+                            
"g.Inject(uuid.Parse(\"f47ac10b-58cc-4372-a567-0e02b2c3d479\"))",
+                            null,
+                            null,
+                            
"g.inject(\"f47ac10b-58cc-4372-a567-0e02b2c3d479\")",

Review Comment:
   I don't think we want to translate to a simple string for JS. It should 
either use 
[utils.js](https://github.com/apache/tinkerpop/blob/5b7eea59a4264f06cc05a76383db2eda480379c4/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/utils.js#L41-L44)
 (might need an extension there) or directly construct a uuid using the same 
uuid library.





> Expand type syntax in grammar in 3.8
> ------------------------------------
>
>                 Key: TINKERPOP-3023
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3023
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language
>    Affects Versions: 3.8.0
>            Reporter: Stephen Mallette
>            Priority: Major
>
> There are certain types commonly used in Gremlin that should have some native 
> support in the grammar:
>  * UUID
>  ** {{UUID()}} - random
>  ** {{UUID('1e077e63-e45a-4f8e-aa00-9b6ffd91f20e')}}
>  * Edge
>  ** {{Edge(11)}} - different than current syntax for Vertex, adjust Vertex to 
> match - drop grammar support for {{{}ReferenceVertex{}}}.
>  * Binary (ByteBuffer)
>  ** {{Binary( '/9j/4AAQSkZJRgABAQEAAAAAAAD/==')}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to