[
https://issues.apache.org/jira/browse/TINKERPOP-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955960#comment-17955960
]
ASF GitHub Bot commented on TINKERPOP-3115:
-------------------------------------------
EchoNullify commented on code in PR #3121:
URL: https://github.com/apache/tinkerpop/pull/3121#discussion_r2124682562
##########
docs/src/upgrade/release-3.8.x.asciidoc:
##########
@@ -30,6 +30,12 @@ complete list of all the modifications that are part of this
release.
=== Upgrading for Users
+==== Auto promotion of number types
Review Comment:
Comments should now all be addressed
> Better handle overflows with sum()
> ----------------------------------
>
> Key: TINKERPOP-3115
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3115
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.7.2
> Reporter: Stephen Mallette
> Priority: Minor
> Labels: breaking
>
> {{code}}
> gremlin> g.inject([(byte) 126, (byte) 2]).sum(local)
> ==>-128
> {{code}}
> that output seems unexpected. oddly it didn't work that way for the global
> version of {{sum()}} because the type auto promoted to {{long}} because there
> was multiplication by the {{bulk}} which was {{long}}. That changed on
> TINKERPOP-3088 though so now even the global version will work like this.
> seems like it would be better to promote they type whenever it didn't fit
> into the space allotted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
