[
https://issues.apache.org/jira/browse/TINKERPOP-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018491#comment-18018491
]
ASF GitHub Bot commented on TINKERPOP-3173:
-------------------------------------------
Cole-Greer commented on PR #3195:
URL: https://github.com/apache/tinkerpop/pull/3195#issuecomment-3259799799
> Feels like tests with nested operations like NOT (A OR B) might be
missing. Essentially tests that show why the ternary logic didn't quite work in
the first place.
The updated tests in the renamed ComparabilitySemanticsTests provided all of
the coverage I wanted to see for this change. I have not looked at special test
cases for AndStep, OrStep, P.and, or P,or as none of these have any special
handling regarding the new comparability semantics, and are not able to
demonstrate the changes.
There were a few existing steps using the NotStep which demonstrate the new
semantics, and have been updated accordingly. It's occurred to me however that
we don't have a dedicated `Not.feature` file at the moment. I'm not sure why
that is, but I can add such a file with basic scenarios as part of this PR.
> Simplify Comparability Semantics
> --------------------------------
>
> Key: TINKERPOP-3173
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3173
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.7.3
> Reporter: Cole Greer
> Priority: Major
>
> As recently discussed on the
> [devlist|https://lists.apache.org/thread/hsqw2tvc72dw4z40nnbbdmygrqx43syr],
> our current system of ternary boolean logic should be simplified to binary
> boolean logic where invalid comparisons simply return false.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
