[
https://issues.apache.org/jira/browse/TINKERPOP-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018002#comment-18018002
]
ASF GitHub Bot commented on TINKERPOP-3173:
-------------------------------------------
xiazcy commented on code in PR #3195:
URL: https://github.com/apache/tinkerpop/pull/3195#discussion_r2320424008
##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/language/grammar/TraversalPredicateVisitorTest.java:
##########
@@ -42,26 +42,26 @@ public class TraversalPredicateVisitorTest {
@Parameterized.Parameters(name = "{0}")
public static Iterable<Object[]> generateTestParameters() {
return Arrays.asList(new Object[][]{
- {"eq(10)", P.eq(10)},
- {"neq(1.0f)", P.neq(1.0f)},
- {"lt(0x11)", P.lt(0x11)},
- {"lte('abc')", P.lte("abc")},
- {"gt(1.0D)", P.gt(1d)},
- {"gte(1L)", P.gte(1L)},
- {"inside(100, 200)", P.inside(100, 200)},
- {"outside(1E11, 2e-11)", P.outside(new Double("1E11"), new
Double("2e-11"))},
- {"between(\"a\", \"e\")", P.between("a", "e")},
- {"within([\"a\", \"e\"])", P.within(Arrays.asList("a", "e"))},
- {"within()", P.within()},
- {"without([1, 2])", P.without(Arrays.asList(1, 2))},
- {"without([1, 2])", P.without(1, 2)},
- {"without(1, 2)", P.without(1, 2)},
- {"without(1)", P.without(1)},
- {"without([1])", P.without(1)},
- {"without()", P.without()},
- {"without(1, [1, 2])", P.without(1, Arrays.asList(1, 2))},
- {"within([1, 2, 3], 1, [1, 2])", P.within(Arrays.asList(1, 2,
3), 1, Arrays.asList(1, 2))},
- {"not(without(1, 2))", P.not(P.without(1, 2))},
+// {"eq(10)", P.eq(10)},
Review Comment:
Note to uncomment these tests given they should be passing.
> Simplify Comparability Semantics
> --------------------------------
>
> Key: TINKERPOP-3173
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3173
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.7.3
> Reporter: Cole Greer
> Priority: Major
>
> As recently discussed on the
> [devlist|https://lists.apache.org/thread/hsqw2tvc72dw4z40nnbbdmygrqx43syr],
> our current system of ternary boolean logic should be simplified to binary
> boolean logic where invalid comparisons simply return false.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
