[ 
https://issues.apache.org/jira/browse/TINKERPOP-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18019675#comment-18019675
 ] 

ASF GitHub Bot commented on TINKERPOP-3161:
-------------------------------------------

xiazcy opened a new pull request, #3206:
URL: https://github.com/apache/tinkerpop/pull/3206

   As noted in the Jira, the .NET serializer has always serialized and 
deserialized bytes as unsigned, while the IO doc specified byte to be signed. 
This is to update the byte serializers to be signed. 
   
   VOTE +1




> Switched to signed bytes in .net
> --------------------------------
>
>                 Key: TINKERPOP-3161
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3161
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>    Affects Versions: 3.7.3
>            Reporter: Cole Greer
>            Priority: Critical
>              Labels: breaking
>
> The `Byte` type in our serializers represents a signed 8-bit integer (as this 
> is what byte in Java represents), however this currently maps to `byte` in 
> .net, which is an unsigned value. The .net serializers should be updated to 
> use `sbyte` instead, to be consistent with the rest of TinkerPop.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to