[
https://issues.apache.org/jira/browse/TINKERPOP-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18020455#comment-18020455
]
ASF GitHub Bot commented on TINKERPOP-3161:
-------------------------------------------
kenhuuu commented on code in PR #3206:
URL: https://github.com/apache/tinkerpop/pull/3206#discussion_r2349979838
##########
CHANGELOG.asciidoc:
##########
@@ -100,6 +100,7 @@ This release also includes changes from <<release-3-7-XXX,
3.7.XXX>>.
* Introduced `GValue` to represent parameterized values in a `GraphTraversal`
* Added optional traversal cache to `GremlinLangScriptEngine`
* Introduced step interfaces for all parameterizable steps
+* switch `gremlin-net` byte serializers to signed bytes (`sbyte`) as per Byte
IO doc
Review Comment:
Nit: Incorrect capitalization and usage of past tense.
> Switched to signed bytes in .net
> --------------------------------
>
> Key: TINKERPOP-3161
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3161
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.7.3
> Reporter: Cole Greer
> Priority: Critical
> Labels: breaking
>
> The `Byte` type in our serializers represents a signed 8-bit integer (as this
> is what byte in Java represents), however this currently maps to `byte` in
> .net, which is an unsigned value. The .net serializers should be updated to
> use `sbyte` instead, to be consistent with the rest of TinkerPop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
