[ 
https://issues.apache.org/jira/browse/TINKERPOP-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18023876#comment-18023876
 ] 

ASF GitHub Bot commented on TINKERPOP-2234:
-------------------------------------------

Cole-Greer commented on code in PR #3211:
URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2392473637


##########
gremlin-language/src/main/antlr4/Gremlin.g4:
##########
@@ -1080,15 +1080,60 @@ traversalDT
     | K_DAY | K_DT DOT K_DAY
     ;
 
-traversalN
-    : K_BYTE | K_N DOT K_BYTE
-    | K_SHORT | K_N DOT K_SHORT
-    | K_INT | K_N DOT K_INT
-    | K_LONG | K_N DOT K_LONG
-    | K_FLOAT | K_N DOT K_FLOAT
-    | K_DOUBLE | K_N DOT K_DOUBLE
-    | K_BIGINT | K_N DOT K_BIGINT
-    | K_BIGDECIMAL | K_N DOT K_BIGDECIMAL
+traversalGType
+    : K_BIGDECIMAL | K_GTYPE DOT K_BIGDECIMAL
+    | K_BIGDECIMALU | K_GTYPE DOT K_BIGDECIMALU
+    | K_BIGINT | K_GTYPE DOT K_BIGINT
+    | K_BIGINTU | K_GTYPE DOT K_BIGINTU
+    | K_BINARY | K_GTYPE DOT K_BINARY
+    | K_BINARYU | K_GTYPE DOT K_BINARYU
+    | K_BOOLEAN | K_GTYPE DOT K_BOOLEAN
+    | K_BOOLEANU | K_GTYPE DOT K_BOOLEANU
+    | K_BYTE | K_GTYPE DOT K_BYTE
+    | K_BYTEU | K_GTYPE DOT K_BYTEU
+    | K_CHAR | K_GTYPE DOT K_CHAR
+    | K_CHARU | K_GTYPE DOT K_CHARU
+    | K_DATETIME | K_GTYPE DOT K_DATETIME
+    | K_DATETIMEU | K_GTYPE DOT K_DATETIMEU
+    | K_DOUBLE | K_GTYPE DOT K_DOUBLE
+    | K_DOUBLEU | K_GTYPE DOT K_DOUBLEU
+    | K_DURATION | K_GTYPE DOT K_DURATION
+    | K_DURATIONU | K_GTYPE DOT K_DURATIONU
+    | K_EDGE | K_GTYPE DOT K_EDGE
+    | K_EDGEU | K_GTYPE DOT K_EDGEU
+    | K_FLOAT | K_GTYPE DOT K_FLOAT
+    | K_FLOATU | K_GTYPE DOT K_FLOATU
+    | K_GRAPH | K_GTYPE DOT K_GRAPH
+    | K_GRAPHU | K_GTYPE DOT K_GRAPHU
+    | K_INT | K_GTYPE DOT K_INT
+    | K_INTU | K_GTYPE DOT K_INTU
+    | K_LIST | K_GTYPE DOT K_LIST
+    | K_LISTU | K_GTYPE DOT K_LISTU
+    | K_LONG | K_GTYPE DOT K_LONG
+    | K_LONGU | K_GTYPE DOT K_LONGU
+    | K_MAP | K_GTYPE DOT K_MAP
+    | K_MAPU | K_GTYPE DOT K_MAPU
+    | K_NULL | K_GTYPE DOT K_NULL
+    | K_NULLU | K_GTYPE DOT K_NULLU
+    | K_NUMBER | K_GTYPE DOT K_NUMBER
+    | K_NUMBERU | K_GTYPE DOT K_NUMBERU
+    | K_PATH | K_GTYPE DOT K_PATH
+    | K_PATHU | K_GTYPE DOT K_PATHU
+    | K_PROPERTY | K_GTYPE DOT K_PROPERTY
+    | K_PROPERTYU | K_GTYPE DOT K_PROPERTYU
+    | K_SET | K_GTYPE DOT K_SET
+    | K_SETU | K_GTYPE DOT K_SETU
+    | K_SHORT | K_GTYPE DOT K_SHORT
+    | K_SHORTU | K_GTYPE DOT K_SHORTU
+    | K_STRING | K_GTYPE DOT K_STRING
+    | K_STRINGU | K_GTYPE DOT K_STRINGU
+    | K_TREE | K_GTYPE DOT K_TREE
+    | K_TREEU | K_GTYPE DOT K_TREEU
+    | K_UUID | K_GTYPE DOT K_UUID

Review Comment:
   Should we accept all of `UUID`, `GType.UUID`, `uuid`, and `GType.uuid` as 
valid GTypes for consistency?





> Introduce Type Predicate
> ------------------------
>
>                 Key: TINKERPOP-2234
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2234
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.4.2
>            Reporter: Stephen Mallette
>            Priority: Major
>
> Provide for a {{typeOf()}} predicate that allows for testing the type of an 
> object which would enable neat things like:
> {code}
> g.V().outE().has('weight',gt(0.1)).inV().path().unfold().is(typeOf(VERTEX))
> {code}
> See the linked DISCUSS thread for more information.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to