[ 
https://issues.apache.org/jira/browse/TINKERPOP-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18023891#comment-18023891
 ] 

ASF GitHub Bot commented on TINKERPOP-2234:
-------------------------------------------

Cole-Greer commented on code in PR #3211:
URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2392575143


##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/DateAddStepTest.java:
##########
@@ -131,7 +132,7 @@ public void shouldAddSecondsForDateCompatibility() {
         assertEquals(expected, __.__(now).dateAdd(DT.second, 15).next());
     }
 
-    @Test
+    @Test @Ignore("need to restruture to account for day light saving changes")

Review Comment:
   Looks like my fix is already picked up here
   ```
   final Calendar cal = Calendar.getInstance(TimeZone.getTimeZone("UTC"));
   ```
   I would expect you can drop this ignore and it should pass now.





> Introduce Type Predicate
> ------------------------
>
>                 Key: TINKERPOP-2234
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2234
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.4.2
>            Reporter: Stephen Mallette
>            Priority: Major
>
> Provide for a {{typeOf()}} predicate that allows for testing the type of an 
> object which would enable neat things like:
> {code}
> g.V().outE().has('weight',gt(0.1)).inV().path().unfold().is(typeOf(VERTEX))
> {code}
> See the linked DISCUSS thread for more information.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to