[
https://issues.apache.org/jira/browse/TINKERPOP-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069723#comment-18069723
]
ASF GitHub Bot commented on TINKERPOP-3225:
-------------------------------------------
codecov-commenter commented on PR #3372:
URL: https://github.com/apache/tinkerpop/pull/3372#issuecomment-4158187658
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3372?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.90%. Comparing base
([`9b46b67`](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`fb7dfdf`](https://app.codecov.io/gh/apache/tinkerpop/commit/fb7dfdfa059739a7e6a76e3427c7e76aeb1388ef?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 445 commits behind head on 3.7-dev.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.7-dev #3372 +/- ##
=============================================
+ Coverage 76.14% 76.90% +0.75%
=============================================
Files 1084 28 -1056
Lines 65160 5308 -59852
Branches 7285 0 -7285
=============================================
- Hits 49616 4082 -45534
+ Misses 12839 1024 -11815
+ Partials 2705 202 -2503
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/3372?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> conjoin has incorrect null handling
> -----------------------------------
>
> Key: TINKERPOP-3225
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3225
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.8.0, 3.7.5
> Reporter: Ken Hu
> Priority: Major
>
> The conjoin() step doesn't behave as stated in the semantics documentation.
> Namely, the "Null values are ignored" isn't being followed.
> {code:java}
> gremlin> g.inject([null]).conjoin("-")
> ==>null
> gremlin> g.inject([null, null]).conjoin("-")
> ==>null {code}
> show that the nulls are being passed through similar to concat() but that
> isn't correct according to the semantics.
> Instead it should be the following:
> {code:java}
> gremlin> g.inject([]).conjoin("+")
> ==>
> gremlin> g.inject([null]).conjoin("+")
> ==>
> gremlin> g.inject([null, null]).conjoin("+")
> ==>{code}
> where similar to empty array, the result is an empty string.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
