[
https://issues.apache.org/jira/browse/TINKERPOP-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18072129#comment-18072129
]
ASF GitHub Bot commented on TINKERPOP-3225:
-------------------------------------------
Cole-Greer commented on PR #3372:
URL: https://github.com/apache/tinkerpop/pull/3372#issuecomment-4210556372
LGTM. Merging to 3.7 seems like the right call to me as it's bringing the
implementation inline with the [semantics
docs](https://tinkerpop.apache.org/docs/3.7.6/dev/provider/#conjoin-step).
VOTE +1
> conjoin has incorrect null handling
> -----------------------------------
>
> Key: TINKERPOP-3225
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3225
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.8.0, 3.7.5
> Reporter: Ken Hu
> Priority: Major
>
> The conjoin() step doesn't behave as stated in the semantics documentation.
> Namely, the "Null values are ignored" isn't being followed.
> {code:java}
> gremlin> g.inject([null]).conjoin("-")
> ==>null
> gremlin> g.inject([null, null]).conjoin("-")
> ==>null {code}
> show that the nulls are being passed through similar to concat() but that
> isn't correct according to the semantics.
> Instead it should be the following:
> {code:java}
> gremlin> g.inject([]).conjoin("+")
> ==>
> gremlin> g.inject([null]).conjoin("+")
> ==>
> gremlin> g.inject([null, null]).conjoin("+")
> ==>{code}
> where similar to empty array, the result is an empty string.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
