[
https://issues.apache.org/jira/browse/TINKERPOP-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076693#comment-18076693
]
ASF GitHub Bot commented on TINKERPOP-3153:
-------------------------------------------
kenhuuu opened a new pull request, #3401:
URL: https://github.com/apache/tinkerpop/pull/3401
https://issues.apache.org/jira/browse/TINKERPOP-3153
Duration is based on GraphBinary's seconds and nanos representation instead
of Java Duration's ISO-8601 string. Despite ISO-8601 being more human-readable,
the lack of support for it from the languages meant that lots of extra parsing
had to be added to make it work. Also, this implementation doesn't preclude a
future overload to Duration() from being added to the grammar.
A 's' suffix was added in addition to the 'c' suffix for users to explicitly
choose a string over a character but string is already the default so it
shouldn't cause any changes.
Support was only added to GLVs that already had support for Char, Duration,
and Binary in GraphBinary.
<!--
Thanks for contributing! Reminders:
+ TARGET the earliest branch where you want the change
3.7-dev -> 3.7.7 (non-breaking only)
3.8-dev -> 3.8.2 (non-breaking only)
master -> 4.0.0
+ Committers will MERGE the PR forward to newer versions
+ ADD entry to the CHANGELOG.asciidoc for the targeted version
Do not reference a JIRA number there
+ ADD JIRA number to title and link in description
+ PRs requires 3 +1s from committers OR
1 +1 and 7 day wait to merge.
+ MORE details: https://s.apache.org/rtnal
-->
> Expand type syntax in grammar in 4.0
> ------------------------------------
>
> Key: TINKERPOP-3153
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3153
> Project: TinkerPop
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Ken Hu
> Priority: Major
>
> Types to add to the grammar in 4.0:
> * Char
> ** Unfortunately '' is already used for strings to match Groovy. Will need
> to look into something nice for this.
> * Duration
> ** Should check to see if Duration can be used for date functions as well
> ** Duration(Long)
> * CompositePdt
> ** Pdt("name", [ : ] )
> * PrimitivePdt
> ** Pdt("name", "value")
> * Tree
> * Graph
> * Binary (ByteBuffer) - moved from 3.8.0
> ** {{Binary( '/9j/4AAQSkZJRgABAQEAAAAAAAD/==')}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
