[
https://issues.apache.org/jira/browse/TINKERPOP-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18077376#comment-18077376
]
ASF GitHub Bot commented on TINKERPOP-3153:
-------------------------------------------
kenhuuu commented on code in PR #3401:
URL: https://github.com/apache/tinkerpop/pull/3401#discussion_r3169246390
##########
docs/src/dev/developer/for-committers.asciidoc:
##########
@@ -385,7 +385,12 @@ appropriate types expected by the tests.
The syntax of the type notation involves a prefix character to help denote the
type, a value between two square
brackets, optionally suffixed with some additional notation depending on the
primary type.
+* Binary - *bin[_xxx_]* - The "xxx" should be replaced with a base64-encoded
string.
+* Character - *char[_xxx_]* - The "xxx" should be replaced with a single UTF-8
character.
* Date - *dt[_xxx_]* - The "xxx" should be ISO 8601 string.
+* Duration - *dur[_xxx_,_yyy_,_zzz_]* - The "xxx" should be replaced a Long
representing seconds, the "yyy" should be
+replaced an Int representing nanoseconds, and the optional "zzz" should be
replaced by a boolean which is true if the
+value is positive and false if its negative.
* Edge - *e[_xxx_]* - The "xxx" should be replaced with a representation of an
edge in the form of the
Review Comment:
We didn't seem to do that for any of the other `@Data...` test files. Any
particular reason you think it would be valuable to do this here? I'm assuming
that at some point these data types will be used in other feature files so
having these tags mentioned would be kind of pointless. You would probably want
a `@SupportsChar` or something later?
> Expand type syntax in grammar in 4.0
> ------------------------------------
>
> Key: TINKERPOP-3153
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3153
> Project: TinkerPop
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Ken Hu
> Priority: Major
>
> Types to add to the grammar in 4.0:
> * Char
> ** Unfortunately '' is already used for strings to match Groovy. Will need
> to look into something nice for this.
> * Duration
> ** Should check to see if Duration can be used for date functions as well
> ** Duration(Long)
> * CompositePdt
> ** Pdt("name", [ : ] )
> * PrimitivePdt
> ** Pdt("name", "value")
> * Tree
> * Graph
> * Binary (ByteBuffer) - moved from 3.8.0
> ** {{Binary( '/9j/4AAQSkZJRgABAQEAAAAAAAD/==')}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
