Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/154#issuecomment-159091761
I have no idea why this is good or bad but if @dalaro says it should be as
he has it, I'm all for it. Also, to answer @dalaro -- no, this is not a heavily
threaded method. This is batch processing and thus, you won't be "firing off
ten thousand times a second."
@dalaro -- QUESTION: Should we do the same for `GiraphGraphComputer`? If
so, can you update your PR for that as well. Also, what about
`TinkerGraphComputer`?
I pulled into a local branch. Tested
`SparkGraphComputerProcessIntegrationTest`. It passed fully. I also ran the
`mvn clean install` to test other non-integration tests for Spark. They all
passed as well.
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---