Github user dalaro commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/154#issuecomment-160962223
I'll open a new PR. Don't merge this one. I extracted the common
executor-related logic into a helper shared between the Giraph and Spark
computers, but much more importantly, my first attempt at this leaks executors.
Nowhere does my patch call `shutdown` or `shutdownNow`. The
`newSingleThreadExecutor` factory method that I invoked internally sets the
core-pool size to 1, so the idle thread could never die, even after its
submission-related work is all done. I resolved this in an incoming PR with a
try-finally construct where the try block constructs the executor and the
finally block invokes `shutdown`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
