Github user spmallette commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/186#issuecomment-169033689
  
    I don't know much about OSGi to properly review/vote on this, so at the 
moment, I'm +0.  
    
    I think I find this situation similar to trying to accept a PR where you 
don't have a clue as to what the code in the PR is doing (you can't say if it's 
"right" or "wrong").  I also know from dealing with past pull requests on OSGi 
(various TinkerPop 2.x projects and Titan) that just altering the pom.xml is 
only the start of OSGi support - it's never been clear to me what else would 
need to be done for "full" support, how we would maintain that, how we would 
keep from breaking that, how it would affect the project as a whole, how it 
would change design decisions, etc.  Answers in this area have been somewhat 
vague and full of variety going from person to person.  
    
    btw, i've known "bundles" to behave weirdly with Grape sometimes (grape not 
finding dependencies).  it would be very bad for the plugin system if 
introducing a "bundle" packaging type messed up things up there.  i think that 
would have to be tested very carefully if we made this change.
    
    Can other committers who are newer to the TinkerPop game comment on this 
issue? @pluradj or @twilmes ?  do you folks have any experience here?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to