Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/186#discussion_r49495490
--- Diff: gremlin-core/pom.xml ---
@@ -37,7 +41,7 @@ limitations under the License.
<dependency>
<groupId>org.yaml</groupId>
<artifactId>snakeyaml</artifactId>
- <version>1.15</version>
+ <version>${snakeyaml.version}</version>
--- End diff --
any reason you turned these into properties? doesn't seem necessary as they
aren't really used anywhere outside of gremlin-core. i think we tend to only
use properties in the root pom.xml when there's a need to keep a value
consistent that might be referenced in multiple places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
