Atman, I'm curious to hear how TinkerPop was chosen as a project for DevFactory. Is TinkerPop's code particularly dirty ;-)
If we want to commit to a certain coding standard, the tooling should be instrumented in the maven build, as Stephen suggested. Then I'd want to make sure that the rule enforcement decisions are documented so developers know the expectations. I wouldn't want it to be bound to a particular IDE. Atman also mentioned unit test coverage. I'd think that would be most valuable for all parties. It would cause you, Atman, to become familiar with TinkerPop code at a deeper level than code style conformity. Finally I'd be cautious with about any tools/packaged introduced to ensure they don't interfere with the Apache license expectations for TinkerPop. -- Jason On Fri, Jan 22, 2016 at 6:42 AM Stephen Mallette <spmalle...@gmail.com> wrote: > Ayman, thanks to you and DevFactory for offering to help. > > I think that static code analysis can be useful, but not really in the > context that DevFactory is offering. I feel as though anyone can setup > those tools and fix problems, but if we really wanted to do that, I think > we'd want it part of the standard build process, tying it up with some > automation. Random pull requests containing "fixes" for the kinds of > problems those tools find aren't really useful if in the same day you > provide those fixes, the rest of the committers introduce a dozen more > problems. It just adds noise to the repo. > > For those that may not know what these pull requests will look like - > here's sample from Titan: > > https://github.com/thinkaurelius/titan/pull/1221/files > https://github.com/thinkaurelius/titan/pull/1223/files > https://github.com/thinkaurelius/titan/pull/1224/files > > The last one actually looks a bit interesting as it may have legitimately > found a bug or two. > > At this point, I'd be +0 if we were taking a vote. I'd be hedging closer to > a +1 if we were committed to working these kinds of tools into our > automated build process and part of all committer's daily development > (which of course comes with some more project overhead). I'd be interested > to hear what others think on this. > > > > > On Fri, Jan 22, 2016 at 12:32 AM, Ayman Abdel Ghany < > aymana.gh...@devfactory.com> wrote: > > > Hello, > > > > I'd like to send you some pull requests to improve the maintainability of > > gremlin. > > > > My company - DevFactory - is sponsoring me to identify and fix code > quality > > issues and improve unit test coverage in open source projects. DevFactory > > is obsessed with code quality and is providing its commercially available > > code quality improvement service for free to qualified open-source > > projects. > > > > If you are interested, please let me know and we will add it to our > > pipeline. Our first step will be to utilize tools like PMD, FindBugs and > > Sonar to identify the most important issues to fix. Once we fix them, > we'll > > follow up with some pull requests. > > > > Thanks, > > Ayman Abdelghany > > >
