[
https://issues.apache.org/jira/browse/TINKERPOP-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139145#comment-15139145
]
ASF GitHub Bot commented on TINKERPOP-916:
------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/216
TINKERPOP-916 Provide more robust SimpleClient implementations.
https://issues.apache.org/jira/browse/TINKERPOP-916
These implementations provide for a no-frills way to test Gremlin Server.
Added methods to collect all messages returned from the server as opposed to
just capturing messages via callback. Updated all integration tests that were
using the old methods.
Tested with: `mvn clean install && mvn verify -pl gremlin-server
-DskipIntegrationTests=false`
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-916
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #216
----
commit 30bfe3edaed6b8e93751a90c22c53650f321971e
Author: Stephen Mallette <[email protected]>
Date: 2016-02-04T20:42:15Z
Provide more robust SimpleClient implementations.
These implementations provide for a no-frills way to test Gremlin Server.
Added methods to collect all messages returned from the server as opposed to
just capturing messages via callback. Updated all integration tests that were
using the old methods.
----
> Develop a better "simple" driver for testing and example purposes
> -----------------------------------------------------------------
>
> Key: TINKERPOP-916
> URL: https://issues.apache.org/jira/browse/TINKERPOP-916
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.2-incubating
>
>
> We currently have a some "simple" drivers here:
> https://github.com/apache/incubator-tinkerpop/tree/b2ef5a369684903086e4c10b81cfbc47ff80f6bd/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/simple
> They are "simple" in that they don't do anything smart and are very
> no-frills. They don't hide very much in their implementations which makes
> them good for forcing certain behaviors in Gremlin Server tests. That said,
> they kinda stink and are awkward to work with. Would be nice if they were a
> bit more refined in what they do.
> I think they should minimally work in such a fashion where you can send a
> blocking request (in addition to callback-style one that's already there of
> course). Basically, it should be easy to send a raw {{RequestMessage}} and
> get back a {{ResponseMessage}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
