GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/297

    TINKERPOP-1268 Interactive and Executor Mode for Console

    This PR covers:
    
    https://issues.apache.org/jira/browse/TINKERPOP-1268
    https://issues.apache.org/jira/browse/TINKERPOP-1157
    https://issues.apache.org/jira/browse/TINKERPOP-1155
    https://issues.apache.org/jira/browse/TINKERPOP-1156
    
    I think that the console is working with a nice level of consistency now. 
We no longer have to warn people that the script they give as an init script is 
different than a they give to `-e` - it all executes in the same environment so 
no more discrepancies.
    
    You can see some examples in the documentation for how `-e` and `-i` are 
used.  The shell script simplified a bit - @dkuppitz  if you see a better way 
to deal with the `getopts` thing please let me know. I need to track `-l` in 
the gremlin.sh because we use it to dynamically set some log4j stuff and other 
debug natured things.  `getopts` kinda feels like overkill but - it's working 
so.....
    
    I tested windows and it seemed to work.
    
    Please give it a shot and see if you can break it. I tried to test as many 
combinations as I could think of but i may have fell short somewhere.
    
    VOTE + 1


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1268

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #297
    
----
commit b1493b5b40434ff82c89790e3142819d569119ed
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-28T11:39:55Z

    Deprecate ScriptExecutor.

commit b6853f052fc2efcf76f9d8e30bf95e6a22349fcc
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-28T17:46:02Z

    Implemented more options for Gremlin Console startup.
    
    Added -i for interactive mode and made -e execute in the Console rather 
than ScriptExecutor. Added switches to show/hide output and added a switch for 
"help". The existing method for -i still works as in "bin/gremlin.sh 
init.groovy"

commit 1ed7043721214b04ebb278ae45503fc893f2b960
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-28T18:01:53Z

    Better exception messaging on failure of -e.

commit 3ce732a3e7113ea707dc39755c2fa2f06a5682b3
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-28T18:08:44Z

    Updated changelog.

commit 05be605cd3df603772b15aad751310ea2d4b4b89
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-28T18:39:21Z

    Allow override of verbosity to quiet when using -e.
    
    Only override if the verbosity is not explicitly set.

commit 620f4787b3b6da01679e2f6b80aa3b1a9693f33a
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-28T18:59:37Z

    Use -i as this is now the preferred way of starting interactive mode

commit 0e513cbc47f0885a0484b194ce81d31218dec6dd
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-28T19:00:04Z

    Fixed up sections for console interactive/execute modes.

commit cd709ecb549d88d13dce0694c2d2d25de70baaf4
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-28T19:02:17Z

    Update upgrade docs for Console changes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to