Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/297#issuecomment-215548386 Looks good to me. I prefer this approach for option parsing: https://github.com/apache/incubator-tinkerpop/blob/master/docker/scripts/build.sh#L40-L50 However, it requires that you handle all possible options and show a usage message if an option is unknown. That probably doesn't fit well in `gremlin.sh`, as the Java side is supposed to handle all "unknown" options and you likely don't want to keep the shell script and the Java side in sync whenever an option is added / removed. VOTE: +1
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---