DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=33453>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453 ------- Additional Comments From [EMAIL PROTECTED] 2006-03-22 03:29 ------- Jonathoan, I was about to try using your patch and noticed a problem. You are using the date of the JSP file to stamp the class file but the isOutDated() method is also taking into account the times of the included JSP files. This can cause a JSP file to be re-compiled on every hit if it includes a file that has a later date. For example, if a.jsp is time-stamped 9:00 and it includes b.jsp which stamped 10:00, then isOutDated () will always return true because the time of the included file is greater than 9:00. Then when you assign the earlier time to the class file, this check will fail again the next time around. I think a better solution is to set the time of the class file to the greatest time of the compiled file AND ALL of it's dependants. In the above scenario, the class file would get a time stamp of 10:00 instead of 9:00 and subsequent checks of isOutDated would return false as expected. The only problem I can forsee is if someone updates the included file, THEN rolls back the original file. That seems like a very obscure case and my solution is still better than the current solution which doesn't account for rollbacks at all (and also wouldn't handle the obscure case). I will attempt a solution but will be on vacation soon so it may be a while before I'm able to post any patches. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
