-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Keiichi,
On 10/26/18 01:01, Keiichi Fujino wrote: > Hi Chris! > > Because the argument svc is basically passed the value of > SND_RX_SEQ (1) | Channel.SND_TX_SEQ (2) | MBR_RX_SEQ (4) | > MBR_TX_SEQ (8), so you need to fix the following in start method. > == if(Channel.SND_TX_SEQ == svc) -> if (Channel.SND_TX_SEQ == (svc > & Channel.SND_TX_SEQ)) == > > In order to avoid warnings, you need to add and implement > EncryptInterceptorMBean. > > Some components (static membership etc.) send channel message at > startup, so you should call "super.start(svc)" after calling > "initCiphers()". > > After the above fix, I configured this interceptor and tested > session replication. It seems to work fine. Excellent feedback. I wasn't sure about the start() method; thanks for clearing that up. I'll definitely add the MBean as well, even though I think it won't be very useful to use via JMX. Thanks, - -chris > 2018年10月26日(金) 1:08 Christopher Schultz > <ch...@christopherschultz.net>: > > Rémy, > > On 10/25/18 11:54, Rémy Maucherat wrote: >>>> On Thu, Oct 25, 2018 at 5:15 PM Christopher Schultz < >>>> ch...@christopherschultz.net> wrote: >>>> >>>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 >>>>> >>>>> All, >>>>> >>>>> Bump. >>>>> >>>>> I have a full patch at this point (still without >>>>> documentation), but this one includes resolution of the IV >>>>> issue and also a set of unit tests which pass. >>>>> >>>>> I'd appreciate it if someone could install this into their >>>>> cluster and see if it works. Just configure the interceptor >>>>> into your interceptor chain and set an encryption key >>>>> (e.g. "cafebabecafebabe"). >>>> >>>> >>>> IMO you should commit it and people will test it then (you >>>> did and it works for you, right ?). With my storeconfig hat >>>> on, the encryptionKey should be more bean like, the poor >>>> thing will break otherwise (again ;) ). > > Okay, I can make the encryption key extractable. > > I don't actually have a cluster available to test.... I've never > gotten one set up and working. I will do that, but it may take some > time . > > The unit tests actually send the data through the > sendMessage/messageReceived methods, so I'm fairly confident it > will wor k. > > I'll write-up the documentation and commit it, then. > > Thanks, -chris >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >> -- Keiichi.Fujino <dev-h...@tomcat.apache.org> > -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvTHEYACgkQHPApP6U8 pFiQPRAAyGhrGQrKV7BTJShAr7qs3IxQUmxXjGbwvr3AzDLY4n2nnvA8kyZkJIgV yS9WAqc7unssIUxrbmsEsT6c4WFhC0OMefvgHjuwZgYkC8YMmsuxTCczK5utSMgE cdjGvM1BZVwA2+OtXLoZrcbeFz1+AQhbn2ma8uR9i1Sr937j/jyISPd5Z+irnI7j s9//RUhjqvV7rkCO6PKBhA0Vt7M8BN8Ys716YmPXs346ey9JMOEct3Ik+o3euPrG yp8oATuwwRDl3EwwsZsgZeSduKoRMz6iGdQXl5iD/3eXus9y1eItebzR69vwXeIT sWA505islh0w3RkBCRQjfQ05tDUmgxX4BQaiPrkIsLkAbsadGleEp17r+P55gBri 3if0l79GS8dd6y/djY6RIbZLu9ZLYIOqPXYz2kkjcm/7JrLy8ccw/Qi5vpPioPVs nmdSi4jgm7/TMLvb96esWcMj7/TN6r4qVWdATqDriFRvNz9+MaX+VSZBtHhD6Pcr dByOXFGXyUzgLxb0mGUrIkqnt05pX6BdU80fCDXNQle6fBibVevFV7Q3Chyd+gmc 4PMmdoaDX99/LFEu/piONcObpLSu5K8+gjU9FWitfXWlGMXPC4ycq5Jn4wzMNHUh 7nWvqGJCk6am6pwo7cHQIOvHL0yP3RBsRTxDUKpMXBzz33cl8ZM= =BDbq -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
