This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 3af1cdda41ff892042e63055a309bc4cacfc1e8b
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Mar 6 12:24:24 2020 +0000
Fix a couple of false positives in NioEndpoint
---
res/findbugs/filter-false-positives.xml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/res/findbugs/filter-false-positives.xml
b/res/findbugs/filter-false-positives.xml
index 1acdd72..93b4473 100644
--- a/res/findbugs/filter-false-positives.xml
+++ b/res/findbugs/filter-false-positives.xml
@@ -1425,6 +1425,18 @@
</Match>
<Match>
<!-- Single condition so no need for wait to be in loop -->
+ <Class name="org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper"/>
+ <Method name="fillReadBuffer"/>
+ <Bug pattern="WA_NOT_IN_LOOP" />
+ </Match>
+ <Match>
+ <!-- Single condition so notify() is OK -->
+ <Class name="org.apache.tomcat.util.net.NioEndpoint$Poller"/>
+ <Method name="processKey"/>
+ <Bug pattern="NO_NOTIFY_NOT_NOTIFYALL" />
+ </Match>
+ <Match>
+ <!-- Single condition so no need for wait to be in loop -->
<Class name="org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper"/>
<Or>
<Method name="read"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
