This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 8debf09c6ff03634070c89e66d5bd60971e843aa Author: Mark Thomas <ma...@apache.org> AuthorDate: Fri Mar 6 12:17:03 2020 +0000 Remove unnecessary code and avoid potential NPEs. Thanks to SpotBugs. --- java/org/apache/catalina/realm/JNDIRealm.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/java/org/apache/catalina/realm/JNDIRealm.java b/java/org/apache/catalina/realm/JNDIRealm.java index a4e66bb..f3b4fd0 100644 --- a/java/org/apache/catalina/realm/JNDIRealm.java +++ b/java/org/apache/catalina/realm/JNDIRealm.java @@ -1321,9 +1321,6 @@ public class JNDIRealm extends RealmBase { // Log the problem for posterity containerLog.error(sm.getString("jndiRealm.exception"), e); - // Close the connection so that it gets reopened next time - close(connection); - // Return "not authenticated" for this request if (containerLog.isDebugEnabled()) containerLog.debug("Returning null principal."); @@ -2296,9 +2293,6 @@ System.out.println("getUserBySearch " + username); // Log the problem for posterity containerLog.error(sm.getString("jndiRealm.exception"), e); - // Close the connection so that it gets reopened next time - close(connection); - // Return "not authenticated" for this request return null; --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org