On 06/04/2020 14:34, ebo...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > ebourg pushed a change to branch master > in repository > https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git. > > > from 5c96c0b Ignore the IntelliJ project files > new 29ea189 Replaced NonClosing{In,Out}putStream with the equivalent > classes from Commons IO
-1. It adds 220k of bloat for no benefit. > new 528ccfa Made the internal classes package private I am close to -1 on this change. I would rather these were left public at this stage in the development of this tool to make it as easy as possible for folks to tinker with this code, re-using the bits that work for them. Longer term I had the possibility in mind that users might need to register custom Converters so making that package private seems very out of place. I get that we can always relax visibility rules later but this change looks premature to me. > new 61ba095 Relocated the dependencies in the shaded jar Again, I am close to -1 on this change. Why? I don't see the need for this. It just makes debugging potentially harder. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
