hazendaz commented on pull request #321: URL: https://github.com/apache/tomcat/pull/321#issuecomment-656784397
Bad idea on adding concatenation (rest is good). That causes lots of extra object creation needlessly. Concatenation is long known to be a problem. This PR is doing 2 things, fixing real issues and then adding unnecessary concatenation in others. While I'm not part of this team, I would suggest this be changed to only address the real issues and not add in concatenation. There are better ways to do that without string builder but this is likely this way to allow easy backports still to 7. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
