hazendaz commented on pull request #321: URL: https://github.com/apache/tomcat/pull/321#issuecomment-656901567
@ChristopherSchultz Sorry my point was that there was more than just one thing going on in this change. Some of the stringBuilders didn't do anything other than add entirely static items so those are all good cleanups on their own as no concatenation nor string builder was necessary. That was what I was referring to. Others switched it to concatenation. The compiler does handle it if the items are entirely static. However, if they are not, it's left to the runtime to figure out. If optimization doesn't matter in this area that is fine. Just pointing that out. As to better way to concat, use Strings class to join but that is java 8 and I'm sure its always better to keep tomcat so it's easily backported to prior versions that are not on java 8. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
