On Thu, Oct 21, 2021 at 10:13 AM Martin Grigorov <mgrigo...@apache.org> wrote:
> > > On Thu, Oct 21, 2021 at 9:56 AM Martin Grigorov <mgrigo...@apache.org> > wrote: > >> >> >> On Wed, Oct 20, 2021 at 3:39 PM Mark Thomas <ma...@apache.org> wrote: >> >>> I'm not seeing those failures with OpenJDK 17.0.1 >>> >> >> I see the test is added 8 days ago, so most probably it is not related to >> the JDK version at all. >> >> >>> >>> The response line and body look to be correct to me. >>> >>> The failure appears to be with the request body. Is it possible you >>> aren't using UTF-8 for the *.java file? You could try using >>> >> >> I just clone the Git repo. It should use the encoding of the file. >> >> >>> "/foo\u20acbar" as the expected canonicalized URI. >>> >> >> I will test it now! >> First, I will replace assertTrue with assertEquals at >> https://github.com/apache/tomcat/commit/fee1f457f287a56d3d490a5ab5b3f643d280ecf5#diff-fae30dfd485f718b7b7d76763204c70a1d7257d319018763b98366d3f446decbR200 >> > > HTTP/1.1 200 > /foo€bar expected:</foo[€]bar> but was:</foo[â<U+0082>¬]bar> > junit.framework.AssertionFailedError: HTTP/1.1 200 > /foo€bar expected:</foo[€]bar> but was:</foo[â<U+0082>¬]bar> > at > org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.doTestCanonicalization(TestCoyoteAdapterCanonicalization.java:200) > at > org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.testCanonicalizationSpecification(TestCoyoteAdapterCanonicalization.java:156) > at jdk.internal.reflect.GeneratedMethodAccessor28.invoke(Unknown > Source) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > Testcase: testCanonicalizationTomcat[49: requestURI[/foo%E2%82%ACbar]] > took 0.011 sec > FAILED > HTTP/1.1 200 > /foo€bar expected:</foo[€]bar> but was:</foo[â<U+0082>¬]bar> > junit.framework.AssertionFailedError: HTTP/1.1 200 > /foo€bar expected:</foo[€]bar> but was:</foo[â<U+0082>¬]bar> > at > org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.doTestCanonicalization(TestCoyoteAdapterCanonicalization.java:200) > at > org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.testCanonicalizationTomcat(TestCoyoteAdapterCanonicalization.java:161) > at jdk.internal.reflect.GeneratedMethodAccessor29.invoke(Unknown > Source) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > >> >> >>> >>> Mark >>> >>> >>> On 20/10/2021 12:53, Martin Grigorov wrote: >>> > Hi, >>> > >>> > Today I've tested JDK 17.0.1 and noticed these failures: >>> > >>> > Testcase: testCanonicalizationSpecification[49: >>> > requestURI[/foo%E2%82%ACbar]] took 0.055 sec >>> > FAILED >>> > HTTP/1.1 200 >>> > /foo€bar >>> > junit.framework.AssertionFailedError: HTTP/1.1 200 >>> > /foo€bar >>> > at >>> > >>> org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.doTestCanonicalization(TestCoyoteAdapterCanonicalization.java:200) >>> > at >>> > >>> org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.testCanonicalizationSpecification(TestCoyoteAdapterCanonicalization.java:156) >>> > at >>> jdk.internal.reflect.GeneratedMethodAccessor28.invoke(Unknown >>> > Source) >>> > at >>> > >>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>> > >>> > Testcase: testCanonicalizationTomcat[49: requestURI[/foo%E2%82%ACbar]] >>> took >>> > 0.087 sec >>> > FAILED >>> > HTTP/1.1 200 >>> > /foo€bar >>> > junit.framework.AssertionFailedError: HTTP/1.1 200 >>> > /foo€bar >>> > at >>> > >>> org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.doTestCanonicalization(TestCoyoteAdapterCanonicalization.java:200) >>> > at >>> > >>> org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.testCanonicalizationTomcat(TestCoyoteAdapterCanonicalization.java:161) >>> > at >>> jdk.internal.reflect.GeneratedMethodAccessor29.invoke(Unknown >>> > Source) >>> > at >>> > >>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>> > >>> > They fail consitently on both x86_64 and aarch64. >>> >> Fails also at TravisCI: https://app.travis-ci.com/github/apache/tomcat/jobs/543217112 > > >>> > Regards, >>> > Martin >>> > >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >>>
