On October 21, 2021 10:09:09 AM UTC, Martin Grigorov <mgrigo...@apache.org> wrote: >On Thu, Oct 21, 2021 at 12:29 PM Mark Thomas <ma...@apache.org> wrote: > >> On 21/10/2021 10:19, Mark Thomas wrote: >> > On 21/10/2021 08:40, Martin Grigorov wrote: >> > >> > <snip/> >> > >> >>> Fails also at TravisCI: >> >>> https://app.travis-ci.com/github/apache/tomcat/jobs/543217112 >> >>> >> >> >> >> diff --git >> >> >> >test/org/apache/catalina/connector/TestCoyoteAdapterCanonicalization.java >> >> >> >test/org/apache/catalina/connector/TestCoyoteAdapterCanonicalization.java >> >> index 710e0c7..37c13ef 100644 >> >> --- >> >> >> >test/org/apache/catalina/connector/TestCoyoteAdapterCanonicalization.java >> >> +++ >> >> >> >test/org/apache/catalina/connector/TestCoyoteAdapterCanonicalization.java >> >> @@ -185,7 +185,7 @@ public class TestCoyoteAdapterCanonicalization >> >> extends >> >> TomcatBaseTest { >> >> "Host: localhost" + CRLF + >> >> CRLF >> >> }); >> >> - client.setResponseBodyEncoding(StandardCharsets.UTF_8); >> >> + // client.setResponseBodyEncoding(StandardCharsets.UTF_8); >> >> >> >> This fixes the problem here. >> > >> > That suggests the server isn't sending the correct bytes. I think >the >> > above change is addressing a symptom rather than the root cause. >> > >> > We need to dig into this some more. >> >> Fixed it. It was the source file encoding. >> > >It works now but I don't quite understand the issue yet. >Both Intellij IDEA and vim say that >TestCoyoteAdapterCanonicalization.java >file is/was UTF-8. >Which source file exactly is ISO_8859_1 ?
The Ant build.xml file is configured to treat all source files as ISO-8859-1. Mark > > >> >> Mark >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
