чт, 13 нояб. 2025 г. в 13:35, Mark Thomas <[email protected]>: > > On 13/11/2025 10:30, [email protected] wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > markt pushed a commit to branch main > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The following commit(s) were added to refs/heads/main by this push: > > new 3dca097687 Fix complete status output with a failed context > > 3dca097687 is described below > > > > commit 3dca097687e935e57d28e9b915f8d8a4b3d3c0a5 > > Author: Mark Thomas <[email protected]> > > AuthorDate: Thu Nov 13 10:29:49 2025 +0000 > > > > Fix complete status output with a failed context > > Before I back port this, what do folks think about adding stateName to > the output? > > It changes the HTML output but no-one should be parsing that (that is > what the JSON is for). > > It adds a property to the JSON output but that should be OK. Anyone > parsing the JSON output should just ignore the new property. > > In summary, I think this is OK to back port but I wanted to see what > other folks thought.
+1 to add "State" (stateName) to the output. It is valuable. 1. I'd prefer to name it "state" instead of "stateName" in JSON. Other concerns 2. Lack of i18n here. Other places in StatusTransformer have i18n, e.g. looking at "writeConnectorsState" there is an "args" argument Though that code is used in "Detailed" status report only 3. Looking at the sources I cannot find where the value for StandardContext.tldScanTime is set. I was wondering, as TLD scanning happens in Jasper (via JasperInitializer and TldScanner classes in o.a.jasper.servlet) and here we are in Catalina. It looks that we missed it when refactoring Jasper initialisation to use JasperInitializer (Tomcat 8.5+). In Tomcat 7 the value was set by https://github.com/apache/tomcat/blob/7.0.x/java/org/apache/catalina/startup/TldConfig.java#L292 I wonder about how valuable it is nowadays. I am +1 to remove it for Tomcat 12 onwards, +0 for earlier versions. Would it be interesting to replace it with something else, and measure in nanoseconds? 4. Spelling of "appendJSonValue". It is a private method, so it may be renamed to "appendJsonValue". Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
