dsoumis commented on code in PR #970:
URL: https://github.com/apache/tomcat/pull/970#discussion_r3051546227
##########
build.xml:
##########
@@ -2109,13 +2109,13 @@
</target>
<target name="test-nio" description="Runs the JUnit test cases for NIO. Does
not stop on errors."
-
depends="-test-name-default,setup-jacoco,test-compile,deploy,test-openssl-exists"
if="${execute.test.nio}">
+
depends="-test-name-default,setup-jacoco,test-compile,deploy,test-openssl-exists,test-tcnative-exists"
if="${execute.test.nio}">
<runtests protocol="org.apache.coyote.http11.Http11NioProtocol"
extension=".NIO" />
</target>
<target name="test-only-nio" description="Runs the JUnit test cases or NIO
without test preparations. Does not stop on errors."
- depends="-test-name-default,setup-jacoco,test-openssl-exists"
if="${execute.test.nio}">
+
depends="-test-name-default,setup-jacoco,test-openssl-exists,test-tcnative-exists"
if="${execute.test.nio}">
Review Comment:
This changes the behavior of test-only-nio target with adding test-compile
dependency. Could split that into two targets and make test-tcnative-exists
depend on a compile-tcnative-check target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
