csutherl commented on code in PR #970:
URL: https://github.com/apache/tomcat/pull/970#discussion_r3095704464
##########
build.xml:
##########
@@ -2109,13 +2109,13 @@
</target>
<target name="test-nio" description="Runs the JUnit test cases for NIO. Does
not stop on errors."
-
depends="-test-name-default,setup-jacoco,test-compile,deploy,test-openssl-exists"
if="${execute.test.nio}">
+
depends="-test-name-default,setup-jacoco,test-compile,deploy,test-openssl-exists,test-tcnative-exists"
if="${execute.test.nio}">
<runtests protocol="org.apache.coyote.http11.Http11NioProtocol"
extension=".NIO" />
</target>
<target name="test-only-nio" description="Runs the JUnit test cases or NIO
without test preparations. Does not stop on errors."
- depends="-test-name-default,setup-jacoco,test-openssl-exists"
if="${execute.test.nio}">
+
depends="-test-name-default,setup-jacoco,test-openssl-exists,test-tcnative-exists"
if="${execute.test.nio}">
Review Comment:
OK, I dropped the compile dependency altogether from test-tcnative-exists
target. Instead I'm using javac to compile the test class, and I had to compile
two more helper classes in the event that they don't exist. So the only change
in the test-only-nio behavior now is that it compiles the test class and the
Library test classes to satisfy the check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
