On 07/05/2026 15:22, Rémy Maucherat wrote:
On Thu, May 7, 2026 at 4:09 PM Mark Thomas <[email protected]> wrote:
On 07/05/2026 08:22, [email protected] wrote:
This is an automated email from the ASF dual-hosted git repository.
rmaucher pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 8173b0451b Javadoc fixes and improvements
8173b0451b is described below
commit 8173b0451b2bfa1aab71acc0aa320e3de99b5734
Author: remm <[email protected]>
AuthorDate: Thu May 7 09:22:28 2026 +0200
Javadoc fixes and improvements
Many of these appear to be unnecessary. Javadoc is being copied verbatim
from over-ridden methods. This doesn't add any value (Javadoc will use
the super class method's Javadoc) and may cause issues since any
subsequent changes to the super class Javadoc will not be picked up.
I will review it (search @Override in the commit message). Sometimes I
noticed it described properly the different behavior of the overridden
method, so it seemed to add some value.
Thanks. My "many" assessment was based on finding several while looking
at a very small sample (the methods now reporting Javadoc errors in
Eclipse - fixes to follow for those shortly) so there might not be the
volume of issues I first thought.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
