On Thu, May 7, 2026 at 4:09 PM Mark Thomas <[email protected]> wrote: > > On 07/05/2026 08:22, [email protected] wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > rmaucher pushed a commit to branch main > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The following commit(s) were added to refs/heads/main by this push: > > new 8173b0451b Javadoc fixes and improvements > > 8173b0451b is described below > > > > commit 8173b0451b2bfa1aab71acc0aa320e3de99b5734 > > Author: remm <[email protected]> > > AuthorDate: Thu May 7 09:22:28 2026 +0200 > > > > Javadoc fixes and improvements > > Many of these appear to be unnecessary. Javadoc is being copied verbatim > from over-ridden methods. This doesn't add any value (Javadoc will use > the super class method's Javadoc) and may cause issues since any > subsequent changes to the super class Javadoc will not be picked up.
Ok, so I found only three that seemed completely useless. Did I miss some ? I'm often testing new open models on my local hardware, and this seemed to be the first generation of models and tools that do something relatively useful. For example, I found the javadoc to be good (maybe better than mine ?). So I decided to go ahead. We'll be able to move on and remove some of the checkstyle filters, with more rounds of improvements. Observations: - I still caught a couple sneaky (and bad) code changes it made :) - This degrades surprisingly little with long context, but the context is still too small - It sometimes added javadoc on items than were not producing warnings - Doing this made me catch one bug (the dreaded jakarta -> javax conversion when backporting to 9.0), so it's not all bad ? Rémy --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
