https://issues.apache.org/bugzilla/show_bug.cgi?id=46947
Summary: Code cleanup patch that removes some obsolete null checks Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: enhancement Priority: P5 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: lkue...@apache.org Created an attachment (id=23432) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23432) Patch against trunk As discussed at ApacheCon with Mark and Peter, here is a patch against trunk that removes obsolete null checks where the variable has already been dereferenced earlier. The patch doesn't fix all issues that Findbugs reports in the "RCN" category. I was not able to confirm the remaining ones and I suspect some false alarms. Note to reviewer: The diffs for Generator.java are quite hard to follow in the patch file, maybe it's easier for you to just remove the "if (attrInfos != null)" check yourself in the original code. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org