On 03/10/2010 06:54 PM, Mark Thomas wrote: > On 10/03/2010 17:46, Remy Maucherat wrote: >> On Wed, 2010-03-10 at 17:35 +0000, ma...@apache.org wrote: >>> Author: markt >>> Date: Wed Mar 10 17:35:43 2010 >>> New Revision: 921464 >>> >>> URL: http://svn.apache.org/viewvc?rev=921464&view=rev >>> Log: >>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48795 >>> If compilation fails, always try to re-compile the next time around >>> >>> Modified: >>> tomcat/trunk/java/org/apache/jasper/JspCompilationContext.java >>> tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java >> >> Great idea in theory. Since compilation is an expensive process, this is >> likely a dos problem however. > > I did consider that but I was working on the basis that in production > you wouldn't (OK shouldn't) have broken JSPs that don't compile. In that > scenario with valid JSPs if you don't pre-compile there will be the > initial recompilation as currently but no further load. > > If we think broken JSPs in production are something we need to handle > then we could make this dependent on the setting of the development mode. > > Thoughts?
Or have an additional switch for that. Cheers Jean-Frederic --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
