https://issues.apache.org/bugzilla/show_bug.cgi?id=55317
--- Comment #20 from Mark Thomas <ma...@apache.org> ---
(In reply to Nick Williams from comment #19)
> (In reply to Jeremy Boynes from comment #18)
> > 1) CopyOnWriteArrayList would simplify managing added transformers and is
> > intended for this use-case.
>
> How have I never heard of this class before? Certainly, mutation operations
> will definitely vastly outnumber traversal operations. Perhaps
> CopyOnWriteArrayList is the way to go here, instead of any locking. Mark?
> Thoughts?
As long as the solution is reasonable and meets the requirements there won't be
any objection from me. I can't speak for any other committer.
> > 4) In the messages, we typically wrap [] around the substituted values i.e.
> > [{0}]
>
> I would challenge "typically". Looks like about 50% of the time to me. If
> I'm being told that only [{0}] is right, I'll change it. But there is
> /plenty/ of code that isn't "correct" if this is the case. How are
> contributors to know which to use? They can't.
All new code uses [{0}] for clarity on what exactly the value is (makes it
easier to spot empty values and unexpected white space). We are fixing older
values slowly over time.
Mark
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
