https://issues.apache.org/bugzilla/show_bug.cgi?id=55317

Nick Williams <nicho...@nicholaswilliams.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30678|0                           |1
        is obsolete|                            |

--- Comment #14 from Nick Williams <nicho...@nicholaswilliams.net> ---
Created attachment 30748
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30748&action=edit
Proposed implementation of this feature

I have attached a patch with the implementation complete. In addition to 10
thorough unit tests, my functional testing with Spring Framework indicates that
it works great.

The only remaining question I have, which may require a slight tweak, is
regarding memory leaks. I can't figure out whether transformers added to the
WebappClassLoader (which will come from application classes) constitute a
potential memory leak. It seems to me that the WebappClassLoader instance is
cleaned up when the application is shut down, so it shouldn't be a problem. But
I wanted to get someone's opinion on whether the WebappClassLoader should clear
out the contents of the "transformers" LinkedList when it shuts down. I'm not
convinced it's necessary, so I left it out for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to