https://bz.apache.org/bugzilla/show_bug.cgi?id=56438
--- Comment #5 from Mark Thomas <ma...@apache.org> --- (In reply to VIN from comment #3) > Please review my patch and let me know in case of any problems. Part 1 looks generally OK. You need to use 4 spaces rather than tabs and I agree with the idea in comment #4 to delog log matches and non-matches. I'm less sure about a message with the counts. I think it is too noisy for info and it the summary is debug then why bother since the individual messages are there. Part 2 needs works. Pluggability scans are more than just fragments and the patch needs to take that into account. Also keep in mind the changes are made to trunk first and then back-ported so if the festure you are implementing isn't in trunk or 8.0.x then patches are required for those versions too. You might find it easier to deal with part 1 first and then part 2. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
