I like the idea to log at the end where the user leaked connections. If that can be done in the RA, it's also fine for me.
-- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Nov 20, 2015 at 4:24 PM, Andy <[email protected]> wrote: > Not sure what you mean by not thread safe as there are never any calls > made on the instances out of context? If anything is done out of context > then it is supposed to be noisy. There is no magic in the delegate wrappers. > > Also have no idea where about the geronimo mechanism. The > org.apache.activemq.ra.ActiveMQConnectionFactory is otherwise injected > directly. As previously queried in the thread, if you have a better way > then please provide it or at least provide more information on how to do it > - can't see into your brain so you'll have to open it up ;-) > > Where else would you keep a reference that is available after everything > is shut down? > > > On 20/11/2015 16:03, Romain Manni-Bucau wrote: > >> Well while it doesnt use any static map ok. >> >> We have all the needed code in geronimo to track it properly without >> eveven >> being bound to AMQ and modify injector code at all. Easy alternative is >> doing the wrapping in the resource defition. This sounds even a good >> transversal feature for debug purposes - like LogSql for datasource. In >> any >> case I wouldnt have it enforced. >> >> Side note: the impl is not thread safe and TCK doesnt test much of it so >> not sure it is a criteria. Master has a @Ignore test for this case waiting >> for AMQ upgrade, can at least validate a simple case. >> >> Does it make sense? >> >> Ps: several master fixed can be linked to this as well like RA sorting for >> destroying of resources >> Le 20 nov. 2015 04:23, "Jean-Louis Monteiro" <[email protected]> a >> écrit : >> >> The logging about leaked connections is definitely useful for users so >>> they >>> can fix. >>> Le 20 nov. 2015 13:16, "Jonathan Gallimore" <[email protected]> a >>> écrit : >>> >>> +1 >>>> >>>> Jon >>>> >>>> On Fri, Nov 20, 2015 at 12:15 PM, Andy Gumbrecht < >>>> >>> [email protected] >>> >>>> wrote: >>>> >>>> The wrapper is passing all tests on 1.7.x. I'd therefore like to keep >>>>> >>>> it >>> >>>> as it only hardens TomEE against connection/session misuse and also >>>>> provides valuable logging information if issues exist. >>>>> >>>>> I'll wait for feedback from everyone before I forward port the wrapper. >>>>> >>>>> >>>>> Andy. >>>>> >>>>> -- >>>>> Andy Gumbrecht >>>>> https://twitter.com/AndyGeeDe >>>>> http://www.tomitribe.com >>>>> >>>>> >>>>> >>>> -- >>>> Jonathan Gallimore >>>> http://twitter.com/jongallimore >>>> http://www.tomitribe.com >>>> >>>> > -- > Andy Gumbrecht > https://twitter.com/AndyGeeDe > >
