+0 if anything is justified and motivated. -1 to only run after making tools green Le 12 mars 2016 20:56, "Raquel Pau Fernández" <raquel...@gmail.com> a écrit :
> Hi, > > In case of using Sonar, walkmod (walkmod.com - an open source tool) could > help you to automatically fix some sonar violations. The Github url of the > sonar plugin is https://github.com/walkmod/walkmod-sonar-plugin > > Raquel > > 2016-03-12 20:49 GMT+01:00 Mark Struberg <strub...@yahoo.de>: > > > yes, fear so as well. > > What _would_ help is to enable sonar for TomEE? > > > > https://analysis.apache.org/dashboard/index/12686 > > > > And then go through the rules which make the most sense and clean that > > parts up? > > > > LieGrue, > > strub > > > > > > > Am 11.03.2016 um 19:44 schrieb Romain Manni-Bucau < > rmannibu...@gmail.com > > >: > > > > > > Then -1 for code "guess" of Idea. A lot of false positives so it > pollutes > > > code and when you read it then you wonder how it can happen where it > > can't > > > in reality. > > > > > > For final and variable inits I don't like commits with that cause it > > moves > > > the code in general and make comparisons between versions/revisions > hard > > > (don't care much about inline "final" addition but care if you need to > > > change line numbers for that). > > > > > > > > > > > > > > > Romain Manni-Bucau > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > > <http://rmannibucau.wordpress.com> | Github < > > https://github.com/rmannibucau> | > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber > > > <http://www.tomitribe.com> > > > > > > 2016-03-11 19:33 GMT+01:00 Andy Gumbrecht <agumbre...@tomitribe.com>: > > > > > >> Nothing to do with formatting. The goal is to get the intellij green > > tick > > >> on files rather than red or orange. Trivial global things like finals, > > 'may > > >> produce nullpointer' and variable inits etc. > > >> > > >> > > >> On 11/03/2016 18:53, Romain Manni-Bucau wrote: > > >> > > >> Hi Andy, > > >> > > >> what's the goal? Thought we finished with any cleanup and decided to > not > > >> do it anymore last year. > > >> > > >> > > >> Romain Manni-Bucau > > >> @rmannibucau <https://twitter.com/rmannibucau> | Blog > > >> <http://rmannibucau.wordpress.com> | Github > > >> <https://github.com/rmannibucau> | LinkedIn > > >> <https://www.linkedin.com/in/rmannibucau> | Tomitriber > > >> <http://www.tomitribe.com> > > >> > > >> 2016-03-11 18:48 GMT+01:00 Andy Gumbrecht <agumbre...@tomitribe.com>: > > >> > > >>> I would like to run a project wide intellij driven cleanup. No fixes, > > >>> just a big cleanup across the board. > > >>> It'll be one big commit. > > >>> > > >>> Any objections? > > >>> > > >>> -- > > >>> Andy Gumbrecht > > >>> https://twitter.com/AndyGeeDe > > >>> http://www.tomitribe.com > > >>> > > >>> > > >> > > >> -- > > >> Andy Gumbrecht > > >> https://twitter.com/AndyGeeDe > > >> http://www.tomitribe.com > > >> > > >> > > > > > > > -- > Raquel Pau > > *"Education is the most powerful weapon which you can use to change the > world**"* > > Nelson Mandela >
