I'll try to get a sonar job for us.
LieGrue,strub
On Saturday, 12 March 2016, 23:24, Jean-Louis Monteiro
<[email protected]> wrote:
+1 let's have the analysis tool set and have a base line. Then as Mark
mentioned work on the rule set and fix.
Intellij warnings are sometimes totally irrelevant. Or just I don't like
the code style. Obviously totally personal but just to mention that I'm not
convinced by a massive changes.
Le 12 mars 2016 20:49, "Mark Struberg" <[email protected]> a écrit :
> yes, fear so as well.
> What _would_ help is to enable sonar for TomEE?
>
> https://analysis.apache.org/dashboard/index/12686
>
> And then go through the rules which make the most sense and clean that
> parts up?
>
> LieGrue,
> strub
>
>
> > Am 11.03.2016 um 19:44 schrieb Romain Manni-Bucau <[email protected]
> >:
> >
> > Then -1 for code "guess" of Idea. A lot of false positives so it pollutes
> > code and when you read it then you wonder how it can happen where it
> can't
> > in reality.
> >
> > For final and variable inits I don't like commits with that cause it
> moves
> > the code in general and make comparisons between versions/revisions hard
> > (don't care much about inline "final" addition but care if you need to
> > change line numbers for that).
> >
> >
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com>
> >
> > 2016-03-11 19:33 GMT+01:00 Andy Gumbrecht <[email protected]>:
> >
> >> Nothing to do with formatting. The goal is to get the intellij green
> tick
> >> on files rather than red or orange. Trivial global things like finals,
> 'may
> >> produce nullpointer' and variable inits etc.
> >>
> >>
> >> On 11/03/2016 18:53, Romain Manni-Bucau wrote:
> >>
> >> Hi Andy,
> >>
> >> what's the goal? Thought we finished with any cleanup and decided to not
> >> do it anymore last year.
> >>
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> >> <http://rmannibucau.wordpress.com> | Github
> >> <https://github.com/rmannibucau> | LinkedIn
> >> <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> >> <http://www.tomitribe.com>
> >>
> >> 2016-03-11 18:48 GMT+01:00 Andy Gumbrecht <[email protected]>:
> >>
> >>> I would like to run a project wide intellij driven cleanup. No fixes,
> >>> just a big cleanup across the board.
> >>> It'll be one big commit.
> >>>
> >>> Any objections?
> >>>
> >>> --
> >>> Andy Gumbrecht
> >>> https://twitter.com/AndyGeeDe
> >>> http://www.tomitribe.com
> >>>
> >>>
> >>
> >> --
> >> Andy Gumbrecht
> >> https://twitter.com/AndyGeeDe
> >> http://www.tomitribe.com
> >>
> >>
>
>
