Which will be awesome if we discuss that here. So, others contributors can put their point of view as well.
If we have a Pull Request for that, we can open a discussion on it. With patch file, this is more complicated for some others see the changes. IMHO. (talking about website/documentation) On Tue, Jul 4, 2017 at 9:38 AM, Ivan Junckes Filho <ivanjunc...@gmail.com> wrote: > Btw, Andy is working with me to put it live so everyone can review. Let's > do this before applying it. > > On Tue, Jul 4, 2017 at 9:25 AM, Ivan Junckes Filho <ivanjunc...@gmail.com> > wrote: > > > I would love that Romain :) > > > > On Tue, Jul 4, 2017 at 9:00 AM, Romain Manni-Bucau < > rmannibu...@gmail.com> > > wrote: > > > >> @Ivan: if Andy is ok and if it helps for you I think he can apply your > >> last > >> patch which looks good and we can make it live to iterate from it from > now > >> on. > >> > >> > >> Romain Manni-Bucau > >> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >> <https://blog-rmannibucau.rhcloud.com> | Old Blog > >> <http://rmannibucau.wordpress.com> | Github < > >> https://github.com/rmannibucau> | > >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > >> <https://javaeefactory-rmannibucau.rhcloud.com> > >> > >> 2017-07-04 13:57 GMT+02:00 Ivan Junckes Filho <ivanjunc...@gmail.com>: > >> > >> > Hello Jon, I would love to help with the documentation for this new > >> > feature. I have the website setup in my local so it is not hard to > write > >> > it. > >> > > >> > I will just need some time as too many things are going on at the > >> moment. > >> > > >> > Ivan > >> > > >> > On Tue, Jul 4, 2017 at 8:46 AM, Jonathan Gallimore < > >> > jonathan.gallim...@gmail.com> wrote: > >> > > >> > > This has been open for a while. I will push the docs for it, but in > >> the > >> > > meantime, please let me know if there are any blockers to merge. > I'll > >> > merge > >> > > it in the next day or so unless there is specific blocking feedback. > >> > > > >> > > Many thanks. > >> > > > >> > > Jon > >> > > > >> > > On Mon, Jul 3, 2017 at 2:48 PM, Jonathan Gallimore < > >> > > jonathan.gallim...@gmail.com> wrote: > >> > > > >> > > > Thanks for the feedback Jonathan! Let me see if I can make some > >> > > > improvements there. Point taken on the example - it shouldn't be > an > >> > issue > >> > > > to add something like that. I can do that, or if someone out there > >> is > >> > > > interested in contributing, let me know and I'll hook you up so > you > >> can > >> > > add > >> > > > it. > >> > > > > >> > > > I'd love to hear from a few more people. I'm conscious that MDBs > and > >> > > > connectors might not be a very much understood part of Java EE. So > >> even > >> > > if > >> > > > you have no idea what this thread is about, or you're curious > about > >> how > >> > > to > >> > > > do certain things with JMS with TomEE, like switch JMS provider, > or > >> add > >> > > > other connectors, or even build your own connector, please do ask > a > >> > > > question either here or on a new thread if that's more suitable > and > >> > I'll > >> > > > try and answer questions and crank out some documentation for > >> review. > >> > > > > >> > > > Jon > >> > > > > >> > > > On Thu, Jun 29, 2017 at 10:31 PM, exabrial12 <exabr...@gmail.com> > >> > wrote: > >> > > > > >> > > >> +1 Looks good to me. > >> > > >> > >> > > >> As always, docs speak a million words. Something like > >> > > >> http://tomee.apache.org/examples-trunk/simple-mdb/README.html > >> would > >> > be > >> > > >> helpful! > >> > > >> > >> > > >> The most important part is to always document your decision > >> process, > >> > > >> through > >> > > >> logging, comments, or docs. The vast majority of the time, it's > not > >> > > >> obvious > >> > > >> through one's source code. > >> > > >> > >> > > >> > >> > > >> > >> > > >> -- > >> > > >> View this message in context: http://tomee-openejb.979440.n4 > >> > > >> .nabble.com/MDB-JMX-Control-tp4681962p4681994.html > >> > > >> Sent from the TomEE Dev mailing list archive at Nabble.com. > >> > > >> > >> > > > > >> > > > > >> > > > >> > > >> > > > > > -- Daniel Cunha https://twitter.com/dvlc_
