Hi Roberto, looks a very good start. I have a few discussion points - not 100% linked to this PR but since it triggers items we'll need to discuss I'm dumping it here:
1. MPService should probably be replaced to use a lookup from the classloader and not a particular location (should work in split distributions probably, thinking to /opt/tomee /opt/mp /opt/apps). Also think we shouldn't need it at all and just have an include (white) list for container jars which are scannable (we have a flag for it, we should just make it configurable with an include/exclude properties and activate it by default probably), wdyt? 2. due to 1 tomee-microprofile shouldn't exist I think (we keep the bundling in apache-tomee) 3. NOTICE references mojarra, is it an error? 4. do we bypass mp.war? (+1 from me) 5. open question - we can create another thread on this one: do we use tomee-maven-plugin to create our assemblies instead of copying 4 times the assembly.xml and attach hack? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> 2018-03-05 13:49 GMT+01:00 Daniel Cunha <daniels...@gmail.com>: > +1 > > 2018-03-05 9:40 GMT-03:00 Roberto Cortez <radcor...@yahoo.com.invalid>: > > > Hi all, > > I've submitted a PR:https://github.com/apache/tomee/pull/122 > > > > With some initial work to build a MicroProfile dist of TomEE, starting > > with the MicroProfile Config. > > Please let me know if this is alright. I plan to add some of the other > > implementations into it as well. > > Thanks! > > Cheers,Roberto > > > > > -- > Daniel "soro" Cunha > https://twitter.com/dvlc_ >
