I generally agree about not adding a microprofile profile. I'd be tempted to just add it to all the existing profiles. What would the size impact of that be?
Also, I think an example showing how config works would be really great. I don't think that has to go in the same PR though. Jon On Mon, Mar 5, 2018 at 2:40 PM, Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > Not sure why gmail messed up the formatting so putting my comments/answers > here instead of inline: > > 1. we have forced scan/exclude in the URLClassLoaderfirst, guess it would > be the exact same kind of config > 2. I got it but there is no spec in MP requiring integration code normally > (config doesn't, fault-tolerance doesn't, jwt doesn't - but can require > some fixes in our secu propag but that's not specific to MP, etc...) > > webprofile and full profiles wars are very rarely used and kind of a legacy > we can drop for tomee 8 but not tomee 7, would be great to not create this > legacy for MP IMHO. We can throw a vote on that, would also allow to drop > the overlay module BTW ;). > > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github <https://github.com/ > rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > <https://www.packtpub.com/application-development/java- > ee-8-high-performance> > > 2018-03-05 15:24 GMT+01:00 Roberto Cortez <radcor...@yahoo.com.invalid>: > > > > > Hi Romain, > > Thank you for your quick reply. > > I did try to make it consistent, following the patterns I was able to > > identify already in the project. > > 1 - I'll +1 on configurable way to whitelist, include or exclude jars > from > > scanning. This would take priority over the default.excludes.2 - If 1 is > > true, yet. On the other hand, I don't know if we are going to require > other > > integrations with the other MP specs. The ideia of that project was to > > concentrate the integration code. In the end if nothing is required than > it > > can go away.3 - I guess it was just copy + paste from other NOTICE4 - +1 > > too. Was just following what was already in. Are the other war's useful > at > > all? Couldn't we get rid of all of them?5 - +1 on tomee plugin to create > > assembly > > Cheers,Roberto On Monday, March 5, 2018, 1:55:53 PM GMT, Romain > > Manni-Bucau <rmannibu...@gmail.com> wrote: > > > > Hi Roberto, looks a very good start. I have a few discussion points - > not > > 100% linked to this PR but since it triggers items we'll need to discuss > > I'm dumping it here: > > > > 1. MPService should probably be replaced to use a lookup from the > > classloader and not a particular location (should work in split > > distributions probably, thinking to /opt/tomee /opt/mp /opt/apps). Also > > think we shouldn't need it at all and just have an include (white) list > for > > container jars which are scannable (we have a flag for it, we should just > > make it configurable with an include/exclude properties and activate it > by > > default probably), wdyt? > > 2. due to 1 tomee-microprofile shouldn't exist I think (we keep the > > bundling in apache-tomee) > > 3. NOTICE references mojarra, is it an error? > > 4. do we bypass mp.war? (+1 from me) > > 5. open question - we can create another thread on this one: do we use > > tomee-maven-plugin to create our assemblies instead of copying 4 times > the > > assembly.xml and attach hack? > > > > > > > > Romain Manni-Bucau > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > <https://rmannibucau.metawerx.net/> | Old Blog > > <http://rmannibucau.wordpress.com> | Github <https://github.com/ > > rmannibucau> | > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > <https://www.packtpub.com/application-development/java- > > ee-8-high-performance> > > > > 2018-03-05 13:49 GMT+01:00 Daniel Cunha <daniels...@gmail.com>: > > > > > +1 > > > > > > 2018-03-05 9:40 GMT-03:00 Roberto Cortez <radcor...@yahoo.com.invalid > >: > > > > > > > Hi all, > > > > I've submitted a PR:https://github.com/apache/tomee/pull/122 > > > > > > > > With some initial work to build a MicroProfile dist of TomEE, > starting > > > > with the MicroProfile Config. > > > > Please let me know if this is alright. I plan to add some of the > other > > > > implementations into it as well. > > > > Thanks! > > > > Cheers,Roberto > > > > > > > > > > > > > > > -- > > > Daniel "soro" Cunha > > > https://twitter.com/dvlc_ > > > > > > > >
