I'm currently pulling the TomEE sandbox to Git from SVN. Seems like a long process, I'll post when it is done. I'd be supportive of experimental work taking place there. When its at the point of being released, I'd prefer it to have its own repo.
Jon On Tue, Mar 27, 2018 at 10:32 PM, Jean-Louis Monteiro < [email protected]> wrote: > I've tried to answer the 2 VOTE threads. > > Another option is to merge and immediately extract the code into a sandbox > project so everyone can clearly see what is reusable or not. > Would that help? > > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > On Mon, Mar 19, 2018 at 11:08 PM, Romain Manni-Bucau < > [email protected]> > wrote: > > > Used most to be explicit and my meaning but your wording is more correct. > > > > > > Le 19 mars 2018 22:46, "Mark Struberg" <[email protected]> a > > écrit : > > > > > heh yea, just keep it going. But keep the idea of probably having > > > something tomee independent in the back of your head please! > > > It's not that we need to go through incubator if we want to move things > > > over to Geronimo later. But it would still be great to avoid > duplications > > > if possible. > > > > Jwt-auth impl doesnt depend on tomee and is reusable so must not be > put > > > in tomee codebase > > > Being french I assume you don't mean 'must not' but rather 'doesn't > need > > > to' or rather 'should not', isn't? > > > Of course people _can_ put it into TomEE. It's just that it doesn't > make > > > the most sense from an ASF wide approach. That doesn't mean that it's > not > > > allowed. > > > > > > LieGrue,strub > > > > > > > > > > > > On Monday, 19 March 2018, 21:46:17 CET, Andy Gumbrecht < > > > [email protected]> wrote: > > > > > > Totally agree Mark! So not sure where the issue lays if any? I just > > > don't see a problem with accepting contributions and refactoring if > > > required in order to get the ball rolling, rather than staring at the > > > ball until becomes a cube, or waiting for it to be a perfect pyramid > ;-) > > > > > > > > > On 19/03/18 17:03, Mark Struberg wrote: > > > > > > > > On Monday, 19 March 2018, 11:05:21 CET, Andy Gumbrecht < > > > [email protected]> wrote: > I don't see TomEE as the center of > > > the world, but somewhere where people > > > >> should be free to work without constantly being told it's not OK to > do > > > so. > > > > No, I didn't mean it that way. It's perfectly fine to do things in > > TomEE > > > of course. And again: TomEE IS important. But if we hit some CDI > problem > > > then we should try to fix it 'upstream' in OpenWebBeans - and not in > > TomEE. > > > And if we hit JAX-RS issues then we should try to fix it in CXF - and > not > > > in TomEE. Got me? > > > > > > > > You know that we had lots of duplication and hacks in TomEE to > 'tweak' > > > OWB. And it did really hurt when the spec did evolve. We cleaned that > up > > > and the code is now much easier to maintain. > > > > The thing I wanted to express is that the barriers for existing ASF > > > commiters are pretty low. If possible then we should fix things where > > they > > > belong to. Yes, sometimes it might be the easiest/quickest to just add > a > > > workaround in TomEE. But often that is not the _correct_ way to do it. > > And > > > in the long term it adds maintenance costs. > > > > > > > > I have to admit that I did just roughly glimpsed over the JWT work, > so > > I > > > cannot even judge whether the JWT part makes sense for Geronimo or not. > > > Will try to catch up in the next few days. > > > > LieGrue,strub > > > > > > > > > > > > > > -- > > > Andy Gumbrecht > > > https://twitter.com/AndyGeeDe > > > http://www.tomitribe.com > > > https://www.tomitribe.io > > > > > > > > > Ubique > > > > > > > > >
